Skip to content

feat: smart account options for ecosystems #5136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 23, 2024
Merged

feat: smart account options for ecosystems #5136

merged 1 commit into from
Oct 23, 2024

Conversation

@joaquim-verges
Copy link
Member

@joaquim-verges joaquim-verges commented Oct 23, 2024 •
edited by pr-codex bot
Loading

Problem solved

CleanShot 2024-10-23 at 21.07.07@2x.png

PR-Codex overview

This PR primarily focuses on enhancing authentication options in the ecosystem by introducing new social icons, modifying UI components, and updating the logic for handling authentication settings.

Detailed summary

  • Added getSocialIcon function and updated usages.
  • Modified the UI for various components to improve layout and styling.
  • Removed unused authentication options (phone, email) and updated types.
  • Enhanced AuthOptionsForm with better form handling and validation.
  • Improved ConnectWalletSocialOptions for displaying social wallet options.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@changeset-bot
Copy link

changeset-bot bot commented Oct 23, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: e5fac80

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Oct 23, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 23, 2024 11:02pm
thirdweb_playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 23, 2024 11:02pm
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 23, 2024 11:02pm
wallet-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 23, 2024 11:02pm

@vercel vercel bot temporarily deployed to Preview – wallet-ui October 23, 2024 07:22 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 October 23, 2024 07:22 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground October 23, 2024 07:22 Inactive
@graphite-app
Copy link
Contributor

graphite-app bot commented Oct 23, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@github-actions github-actions bot added the Dashboard Involves changes to the Dashboard. label Oct 23, 2024
@joaquim-verges Graphite App
Copy link
Member Author

joaquim-verges commented Oct 23, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @joaquim-verges and the rest of your teammates on Graphite Graphite

@joaquim-verges joaquim-verges marked this pull request as ready for review October 23, 2024 07:22
@github-actions
Copy link
Contributor

github-actions bot commented Oct 23, 2024 •
edited
Loading

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 42.81 KB (0%) 857 ms (0%) 2.4 s (-35.82% 🔽) 3.3 s
thirdweb (cjs) 102.66 KB (0%) 2.1 s (0%) 6 s (-11.23% 🔽) 8.1 s
thirdweb (minimal + tree-shaking) 4.84 KB (0%) 97 ms (0%) 131 ms (-3.29% 🔽) 228 ms
thirdweb/chains (tree-shaking) 498 B (0%) 10 ms (0%) 64 ms (-21.99% 🔽) 74 ms
thirdweb/react (minimal + tree-shaking) 17.33 KB (0%) 347 ms (0%) 690 ms (-10.04% 🔽) 1.1 s

@codecov
Copy link

codecov bot commented Oct 23, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 20.00000% with 4 lines in your changes missing coverage. Please review.

Project coverage is 45.45%. Comparing base (3cf0039) to head (e5fac80).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
.../web/wallets/shared/ConnectWalletSocialOptions.tsx 0.00% 2 Missing ⚠️
.../ui/ConnectWallet/screens/LinkedProfilesScreen.tsx 0.00% 1 Missing ⚠️
...irdweb/src/react/web/ui/components/WalletImage.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #5136      +/-   ##
==========================================
+ Coverage   45.43%   45.45%   +0.02%     
==========================================
  Files        1066     1065       -1     
  Lines       55150    55122      -28     
  Branches     3974     3975       +1     
==========================================
- Hits        25055    25054       -1     
+ Misses      29403    29376      -27     
  Partials      692      692
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from 3cf0039
packages 40.47% <20.00%> (+0.02%) ⬆️

*This pull request uses carry forward flags. Click here to find out more.

Files with missing lines Coverage Δ
...ckages/thirdweb/src/react/core/utils/walletIcon.ts 57.83% <100.00%> (ø)
.../ui/ConnectWallet/screens/LinkedProfilesScreen.tsx 1.45% <0.00%> (ø)
...irdweb/src/react/web/ui/components/WalletImage.tsx 2.66% <0.00%> (ø)
.../web/wallets/shared/ConnectWalletSocialOptions.tsx 7.14% <0.00%> (ø)

... and 1 file with indirect coverage changes

@joaquim-verges joaquim-verges changed the title refactor: consolidate ecosystem auth and smart account options feat: smart account options for ecosystems Oct 23, 2024
@joaquim-verges joaquim-verges force-pushed the refactor_consolidate_ecosystem_auth_and_smart_account_options branch from 872136d to bc54d53 Compare October 23, 2024 08:14
@joaquim-verges joaquim-verges force-pushed the refactor_consolidate_ecosystem_auth_and_smart_account_options branch from bc54d53 to 5b0dca7 Compare October 23, 2024 08:25
@joaquim-verges joaquim-verges force-pushed the refactor_consolidate_ecosystem_auth_and_smart_account_options branch from 5b0dca7 to a4f4561 Compare October 23, 2024 18:17
@joaquim-verges joaquim-verges force-pushed the refactor_consolidate_ecosystem_auth_and_smart_account_options branch from a4f4561 to d41408a Compare October 23, 2024 19:56
@MananTank MananTank force-pushed the refactor_consolidate_ecosystem_auth_and_smart_account_options branch from d41408a to e5fac80 Compare October 23, 2024 22:48
@joaquim-verges joaquim-verges merged commit 60d2190 into main Oct 23, 2024
30 of 31 checks passed
@joaquim-verges joaquim-verges deleted the refactor_consolidate_ecosystem_auth_and_smart_account_options branch October 23, 2024 23:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MananTank MananTank MananTank approved these changes

@jnsdls jnsdls Awaiting requested review from jnsdls

@gregfromstl gregfromstl Awaiting requested review from gregfromstl

@edwardysun edwardysun Awaiting requested review from edwardysun

Assignees

No one assigned

Labels

Dashboard Involves changes to the Dashboard. packages

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@joaquim-verges @MananTank